From f09e367d5327f1d61edc01976682f00dd97d274c Mon Sep 17 00:00:00 2001
From: Johnathon Slightham <slighthamj@gmail.com>
Date: Mon, 2 Mar 2026 00:39:01 -0500
Subject: [PATCH] Stop returning connections between modules that do not exist

---
 src/libcontrol.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/libcontrol.cpp b/src/libcontrol.cpp
index 5542c57..2c29b9d 100644
--- a/src/libcontrol.cpp
+++ b/src/libcontrol.cpp
@@ -59,11 +59,15 @@ std::vector<std::weak_ptr<Module>> RobotController::getModules() {
 
 std::vector<Flatbuffers::ModuleConnectionInstance> RobotController::getConnections() {
     std::vector<Flatbuffers::ModuleConnectionInstance> out;
-    std::shared_lock lock(m_connection_lock);
+    std::shared_lock module_lock(m_module_lock);
+    std::shared_lock conn_lock(m_connection_lock);
 
     for (auto const &[_, value] : m_connection_map) {
         for (const auto conn : value) {
-            out.push_back(conn);
+            if (m_id_to_module.contains(conn.from_module_id) &&
+                m_id_to_module.contains(conn.to_module_id)) {
+                out.push_back(conn);
+            }
         }
     }
     return out;